Rainbow website + base data

NotBrioche commented

2026-04-29 17:49:41 +02:00

Owner

No description provided.

Aitaneuh was assigned by NotBrioche

2026-04-29 17:49:41 +02:00

NotBrioche added 2 commits

2026-04-29 17:49:42 +02:00

Base website 18bf6ca1a8

Contributors image 0b9d519abf

Aitaneuh commented

2026-04-29 23:32:41 +02:00

Member

Nice ! You already did a very good job as a POC.

To go further I suggest you trying to add like a controller to avoid directly using the json and to prepare the architecture to maybe later use a DB to store our projects so by moving the json logic back to a controller it will be easier to then replace the JSON with a DB without modifying Project.vue file.

Also in Project.vue file, I suggest you add a v-if p.url so that the visit button don't show when no url is provided.

Last thing in Project.vue could be to display "Contributor" instead of "Contributors" if there is only one but as I said it's not that important.

In both App.vue and RainbowSelector.vue, try replacing variable name "c" with something more meaningful because it took me some time to understand what was behind that c variable

When all of that is done fell free to add the commits to the PR, I'll review everything and eventually close the WIP and merge it to main.

BTW : I'm not talking about style for now but it will also need some work but you're right to first focus on building a POC then adding the enhancements.

Edited : Also, don't you think the color showed should only be the one that at least one project uses ? Like instead of having them directly wrote in the code, we should display the ones assigned to at least one project I think. (Another reason to do a controller with the project kappa)

Nice ! You already did a very good job as a POC. To go further I suggest you trying to add like a controller to avoid directly using the json and to prepare the architecture to maybe later use a DB to store our projects so by moving the json logic back to a controller it will be easier to then replace the JSON with a DB without modifying Project.vue file. Also in Project.vue file, I suggest you add a v-if p.url so that the visit button don't show when no url is provided. Last thing in Project.vue could be to display "Contributor" instead of "Contributors" if there is only one but as I said it's not that important. In both App.vue and RainbowSelector.vue, try replacing variable name "c" with something more meaningful because it took me some time to understand what was behind that c variable When all of that is done fell free to add the commits to the PR, I'll review everything and eventually close the WIP and merge it to main. BTW : I'm not talking about style for now but it will also need some work but you're right to first focus on building a POC then adding the enhancements. Edited : Also, don't you think the color showed should only be the one that at least one project uses ? Like instead of having them directly wrote in the code, we should display the ones assigned to at least one project I think. (Another reason to do a controller with the project kappa)

NotBrioche commented

2026-04-30 09:10:01 +02:00

Author

Owner

Sure, will do the modifications !
I just didn't clearly understood your edited part. Do you mind rephrasing it ?

Sure, will do the modifications ! I just didn't clearly understood your edited part. Do you mind rephrasing it ?

Aitaneuh commented

2026-04-30 11:59:14 +02:00

Member

Yes sure, let me rewrite that in a more understandable way.
So what I was saying is instead of having the rainbow selector displaying every color possible even if some colors don't have projects associated with them, it could be better to work the other way and building the rainbow for only the colors that are in projects source.

Let me give you an example : if we have 5 projects, 1 blue, 1 red, 2 orange and 1 black. The RainbowSelector should only have 4 colors avalaible (blue, red, orange and black) instead of the full rainbow. So that when you click on a color, you at least have one project showed and not just none like for now if we click on purple for example which hasn't any projects assigned to it.

I don't know if it was a better explaination but feel free to ask me for more detail or just to tell me your opinion on that modifciation and how do you see the RainbowSelector evolving in the futur.

Yes sure, let me rewrite that in a more understandable way. So what I was saying is instead of having the rainbow selector displaying every color possible even if some colors don't have projects associated with them, it could be better to work the other way and building the rainbow for only the colors that are in projects source. Let me give you an example : if we have 5 projects, 1 blue, 1 red, 2 orange and 1 black. The RainbowSelector should only have 4 colors avalaible (blue, red, orange and black) instead of the full rainbow. So that when you click on a color, you at least have one project showed and not just none like for now if we click on purple for example which hasn't any projects assigned to it. I don't know if it was a better explaination but feel free to ask me for more detail or just to tell me your opinion on that modifciation and how do you see the RainbowSelector evolving in the futur.

NotBrioche commented

2026-04-30 12:23:09 +02:00

Author

Owner

I see, I'll think of a way to make it. Not quite sure of how will the result look like.
The main goal was to have a selector for all the projects and that's it.

I see, I'll think of a way to make it. Not quite sure of how will the result look like. The main goal was to have a selector for all the projects and that's it.

Aitaneuh commented

2026-04-30 12:42:31 +02:00

Member

yeah I see, keep it as you think it's best. You definitly know better than me what was your goal by making this RainbowSelector and I trust you for that.