Fabcorp/Fabcorp-Website
2
2
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

added support for personal links to team members #12

Closed
Aitaneuh wants to merge 1 commit from feature/member-links into main
pull from: feature/member-links
merge into: Fabcorp:main
Conversation 2 Commits 1 Files changed 2 +75 -15
Aitaneuh commented 2026-05-06 18:05:05 +02:00
Member
Copy link

You can now add links to your github. your twitter or a personal website with a nice looking icon under your team member page.

image

You can now add links to your github. your twitter or a personal website with a nice looking icon under your team member page. ![image](/attachments/d365348d-79ed-4bd6-95c1-3fb17ddba592)
image.png
51 KiB
NotBrioche commented 2026-05-07 18:12:39 +02:00
Owner
Copy link

Hey there,
Great intuition but I would be moving the icons definitions in another file. A thing that would be great is having a component that decomposes the URL to show the right icon and get a fallback one if none is found. Links are also dynamic as said in Fabcorp/Fabcorp-Website!13

Hey there, Great intuition but I would be moving the icons definitions in another file. A thing that would be great is having a component that decomposes the URL to show the right icon and get a fallback one if none is found. Links are also dynamic as said in Fabcorp/Fabcorp-Website!13
NotBrioche locked as Resolved and limited conversation to collaborators 2026-05-11 21:23:26 +02:00
NotBrioche commented 2026-05-11 21:23:45 +02:00
Owner
Copy link

Resolved with Fabcorp/Fabcorp-Website!13

Resolved with Fabcorp/Fabcorp-Website!13
NotBrioche closed this pull request 2026-05-11 21:23:51 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
This discussion has been locked. Commenting is limited to contributors.
Reviewers
No reviewers
Labels
Clear labels
  
state: blocked

   
state: changes-requested

   
state: completed

   
state: inactive

   
state: in-progress

   
state: refused

   
state: review-required

   
type: backlog

   
type: bug

   
type: chore

   
type: docs

   
type: duplicate

   
type: feature

   
type: other

   
type: refactor
No labels
state: blocked
state: changes-requested
state: completed
state: inactive
state: in-progress
state: refused
state: review-required
type: backlog
type: bug
type: chore
type: docs
type: duplicate
type: feature
type: other
type: refactor
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Depends on
#13 customized each member part
Fabcorp/Fabcorp-Website
Reference
Fabcorp/Fabcorp-Website!12
No description provided.