Fabcorp/Fabcorp-Website
2
2
Fork 0
Code Issues 1 Pull requests 2 Projects Releases Packages Wiki Activity Actions

aitaneuh-style #3

Merged
NotBrioche merged 9 commits from aitaneuh-style into main 2026-05-01 21:58:44 +02:00
Conversation 7 Commits 9 Files changed 6 +223 -76
Aitaneuh commented 2026-05-01 01:19:46 +02:00
Member
Copy link

I made some good progress to improve the style of the website. I still have some idea like replacing the orange hover of a project card by the color of the project itself but i havent feagured out how that works yet.

I made some good progress to improve the style of the website. I still have some idea like replacing the orange hover of a project card by the color of the project itself but i havent feagured out how that works yet.
NotBrioche commented 2026-05-01 16:49:41 +02:00
Owner
Copy link

Hey there!
That's a great design, definitely better than mine. Still I noticed some points that can be improved.
I'll work on it and make a commit for it. After that if everything works for you, I'll merge the branch.

A thing I can ask you right now is : are you sure to have Prettier formatter installed ? With changes applied to index.html it seems your IDE doesn't apply the format.

Hey there! That's a great design, definitely better than mine. Still I noticed some points that can be improved. I'll work on it and make a commit for it. After that if everything works for you, I'll merge the branch. A thing I can ask you right now is : are you sure to have Prettier formatter installed ? With changes applied to `index.html` it seems your IDE doesn't apply the format.
Aitaneuh commented 2026-05-01 19:34:58 +02:00
Author
Member
Copy link

Hello,

FIrst you were right I my default formatter wasn't set to Prettier.

I was just wondering if you were going to continue adding commits to the PR because right now the project page is broken... image

Hello, FIrst you were right I my default formatter wasn't set to Prettier. I was just wondering if you were going to continue adding commits to the PR because right now the project page is broken... ![image](/attachments/ea3395d2-7b04-49a5-8619-0b455de274f4)
image.png
255 KiB
NotBrioche commented 2026-05-01 19:39:47 +02:00
Owner
Copy link

My bad hadn't seen this

My bad hadn't seen this
NotBrioche commented 2026-05-01 19:41:14 +02:00
Owner
Copy link

The Card beeing on the right isn't a bug, I changed the flex display into a grid, Just want your confirmation with this before merging

The Card beeing on the right isn't a bug, I changed the `flex` display into a `grid`, Just want your confirmation with this before merging
Aitaneuh commented 2026-05-01 20:51:33 +02:00
Author
Member
Copy link

mmmh I don't wanna be rude or anything but on my screen the card appears on the left of the screen but i'm not saying you don't know your right and your left...

Anyway the fact that the card is cut in the middle and stuck in the window border is obviously not planned right so we need to fix this ?

mmmh I don't wanna be rude or anything but on my screen the card appears on the left of the screen but i'm not saying you don't know your right and your left... Anyway the fact that the card is cut in the middle and stuck in the window border is obviously not planned right so we need to fix this ?
👀 1
Aitaneuh commented 2026-05-01 21:36:42 +02:00
Author
Member
Copy link

for now this works for me but the real problem comes from the fixed width of a project card with is defined to 350px for now.

Feel free to accept the PR like that or make it responsive if you want.

for now this works for me but the real problem comes from the fixed width of a project card with is defined to 350px for now. Feel free to accept the PR like that or make it responsive if you want.
NotBrioche approved these changes 2026-05-01 21:58:33 +02:00
NotBrioche deleted branch aitaneuh-style 2026-05-01 21:58:44 +02:00
NotBrioche locked as Resolved and limited conversation to collaborators 2026-05-06 14:54:51 +02:00
This discussion has been locked. Commenting is limited to contributors.
Reviewers
No reviewers
NotBrioche
Labels
Clear labels
  
state: blocked

   
state: changes-requested

   
state: completed

   
state: inactive

   
state: in-progress

   
state: refused

   
state: review-required

   
type: backlog

   
type: bug

   
type: chore

   
type: docs

   
type: duplicate

   
type: feature

   
type: other

   
type: refactor
No labels
state: blocked
state: changes-requested
state: completed
state: inactive
state: in-progress
state: refused
state: review-required
type: backlog
type: bug
type: chore
type: docs
type: duplicate
type: feature
type: other
type: refactor
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
NotBrioche
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Fabcorp/Fabcorp-Website!3
No description provided.